linux-kernel - Re: [PATCH -tip v14 07/12] tracing: Introduce TRACE_FIELD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090819135802.GA4972@nowhere>
Date:	Wed, 19 Aug 2009 15:58:05 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Masami Hiramatsu <mhiramat@...hat.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>,
	lkml <linux-kernel@...r.kernel.org>,
	systemtap <systemtap@...rces.redhat.com>,
	kvm <kvm@...r.kernel.org>,
	DLE <dle-develop@...ts.sourceforge.net>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Avi Kivity <avi@...hat.com>, Andi Kleen <ak@...ux.intel.com>,
	Christoph Hellwig <hch@...radead.org>,
	"Frank Ch. Eigler" <fche@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, Jason Baron <jbaron@...hat.com>,
	Jim Keniston <jkenisto@...ibm.com>,
	"K.Prasad" <prasad@...ux.vnet.ibm.com>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Li Zefan <lizf@...fujitsu.com>,
	PrzemysławPawełczyk <przemyslaw@...elczyk.it>,
	Roland McGrath <roland@...hat.com>,
	Sam Ravnborg <sam@...nborg.org>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Tom Zanussi <tzanussi@...il.com>,
	Vegard Nossum <vegard.nossum@...il.com>
Subject: Re: [PATCH -tip v14 07/12] tracing: Introduce TRACE_FIELD_ZERO()
	macro

On Tue, Aug 18, 2009 at 10:20:11PM -0400, Masami Hiramatsu wrote:
> Frederic Weisbecker wrote:
> > On Thu, Aug 13, 2009 at 04:35:01PM -0400, Masami Hiramatsu wrote:
> >> Use TRACE_FIELD_ZERO(type, item) instead of TRACE_FIELD_ZERO_CHAR(item).
> >> This also includes a fix of TRACE_ZERO_CHAR() macro.
> > 
> > 
> > I can't find what the fix is about (see below)
> 
> Ah, OK. This patch actually includes two parts.
> 
> One is introducing TRACE_FIELD_ZERO which is more generic than
> TRACE_FIELD_ZERO_CHAR, I think.
> 
> Another is a typo fix of TRACE_ZERO_CHAR.


Ok.

 
> >>  
> >> +#undef TRACE_FIELD_ZERO
> >> +#define TRACE_FIELD_ZERO(type, item)
> >> +
> > 
> > 
> > 
> > Is it about the above moving?
> > If so, could you just tell so that I can add something about
> > it in the changelog.
> 
> No, I assume that TRACE_ZERO_CHAR is just a typo of TRACE_FIELD_ZERO_CHAR.
> (because I couldn't find any other TRACE_ZERO_CHAR)
> 
> BTW, this patch may not be needed after applying patch 10/12, since
> it removes ftrace event definitions of TRACE_KPROBE/KRETPROBE.
> 
> Perhaps, would I better merge and split those additional patches(and
> remove this change)?
> (It also could make the incremental review hard...)
> 
> Thank you,
> 


No let's keep it as is. It should be fine.

Thanks.


> -- 
> Masami Hiramatsu
> 
> Software Engineer
> Hitachi Computer Products (America), Inc.
> Software Solutions Division
> 
> e-mail: mhiramat@...hat.com
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/