| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4A8B615B.7000200@redhat.com>
Date: Tue, 18 Aug 2009 22:20:11 -0400
From: Masami Hiramatsu <mhiramat@...hat.com>
To: Frederic Weisbecker <fweisbec@...il.com>
CC: Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>,
lkml <linux-kernel@...r.kernel.org>,
systemtap <systemtap@...rces.redhat.com>,
kvm <kvm@...r.kernel.org>,
DLE <dle-develop@...ts.sourceforge.net>,
Ananth N Mavinakayanahalli <ananth@...ibm.com>,
Avi Kivity <avi@...hat.com>, Andi Kleen <ak@...ux.intel.com>,
Christoph Hellwig <hch@...radead.org>,
"Frank Ch. Eigler" <fche@...hat.com>,
"H. Peter Anvin" <hpa@...or.com>, Jason Baron <jbaron@...hat.com>,
Jim Keniston <jkenisto@...ibm.com>,
"K.Prasad" <prasad@...ux.vnet.ibm.com>,
Lai Jiangshan <laijs@...fujitsu.com>,
Li Zefan <lizf@...fujitsu.com>,
PrzemysławPawełczyk <przemyslaw@...elczyk.it>,
Roland McGrath <roland@...hat.com>,
Sam Ravnborg <sam@...nborg.org>,
Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
Tom Zanussi <tzanussi@...il.com>,
Vegard Nossum <vegard.nossum@...il.com>
Subject: Re: [PATCH -tip v14 07/12] tracing: Introduce TRACE_FIELD_ZERO()
macro
Frederic Weisbecker wrote:
> On Thu, Aug 13, 2009 at 04:35:01PM -0400, Masami Hiramatsu wrote:
>> Use TRACE_FIELD_ZERO(type, item) instead of TRACE_FIELD_ZERO_CHAR(item).
>> This also includes a fix of TRACE_ZERO_CHAR() macro.
>
>
> I can't find what the fix is about (see below)
Ah, OK. This patch actually includes two parts.
One is introducing TRACE_FIELD_ZERO which is more generic than
TRACE_FIELD_ZERO_CHAR, I think.
Another is a typo fix of TRACE_ZERO_CHAR.
>>
>> Signed-off-by: Masami Hiramatsu <mhiramat@...hat.com>
>> Cc: Ananth N Mavinakayanahalli <ananth@...ibm.com>
>> Cc: Avi Kivity <avi@...hat.com>
>> Cc: Andi Kleen <ak@...ux.intel.com>
>> Cc: Christoph Hellwig <hch@...radead.org>
>> Cc: Frank Ch. Eigler <fche@...hat.com>
>> Cc: Frederic Weisbecker <fweisbec@...il.com>
>> Cc: H. Peter Anvin <hpa@...or.com>
>> Cc: Ingo Molnar <mingo@...e.hu>
>> Cc: Jason Baron <jbaron@...hat.com>
>> Cc: Jim Keniston <jkenisto@...ibm.com>
>> Cc: K.Prasad <prasad@...ux.vnet.ibm.com>
>> Cc: Lai Jiangshan <laijs@...fujitsu.com>
>> Cc: Li Zefan <lizf@...fujitsu.com>
>> Cc: Przemysław Pawełczyk <przemyslaw@...elczyk.it>
>> Cc: Roland McGrath <roland@...hat.com>
>> Cc: Sam Ravnborg <sam@...nborg.org>
>> Cc: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
>> Cc: Steven Rostedt <rostedt@...dmis.org>
>> Cc: Tom Zanussi <tzanussi@...il.com>
>> Cc: Vegard Nossum <vegard.nossum@...il.com>
>> ---
>>
>> kernel/trace/trace_event_types.h | 4 ++--
>> kernel/trace/trace_export.c | 16 ++++++++--------
>> 2 files changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/kernel/trace/trace_event_types.h b/kernel/trace/trace_event_types.h
>> index 6db005e..e74f090 100644
>> --- a/kernel/trace/trace_event_types.h
>> +++ b/kernel/trace/trace_event_types.h
>> @@ -109,7 +109,7 @@ TRACE_EVENT_FORMAT(bprint, TRACE_BPRINT, bprint_entry, ignore,
>> TRACE_STRUCT(
>> TRACE_FIELD(unsigned long, ip, ip)
>> TRACE_FIELD(char *, fmt, fmt)
>> - TRACE_FIELD_ZERO_CHAR(buf)
>> + TRACE_FIELD_ZERO(char, buf)
>> ),
>> TP_RAW_FMT("%08lx (%d) fmt:%p %s")
>> );
>> @@ -117,7 +117,7 @@ TRACE_EVENT_FORMAT(bprint, TRACE_BPRINT, bprint_entry, ignore,
>> TRACE_EVENT_FORMAT(print, TRACE_PRINT, print_entry, ignore,
>> TRACE_STRUCT(
>> TRACE_FIELD(unsigned long, ip, ip)
>> - TRACE_FIELD_ZERO_CHAR(buf)
>> + TRACE_FIELD_ZERO(char, buf)
>> ),
>> TP_RAW_FMT("%08lx (%d) fmt:%p %s")
>> );
>> diff --git a/kernel/trace/trace_export.c b/kernel/trace/trace_export.c
>> index 71c8d7f..b0ac92c 100644
>> --- a/kernel/trace/trace_export.c
>> +++ b/kernel/trace/trace_export.c
>> @@ -42,9 +42,9 @@ extern void __bad_type_size(void);
>> if (!ret) \
>> return 0;
>>
>> -#undef TRACE_FIELD_ZERO_CHAR
>> -#define TRACE_FIELD_ZERO_CHAR(item) \
>> - ret = trace_seq_printf(s, "\tfield:char " #item ";\t" \
>> +#undef TRACE_FIELD_ZERO
>> +#define TRACE_FIELD_ZERO(type, item) \
>> + ret = trace_seq_printf(s, "\tfield:" #type " " #item ";\t" \
>> "offset:%u;\tsize:0;\n", \
>> (unsigned int)offsetof(typeof(field), item)); \
>> if (!ret) \
>> @@ -92,9 +92,6 @@ ftrace_format_##call(struct ftrace_event_call *unused, \
>>
>> #include "trace_event_types.h"
>>
>> -#undef TRACE_ZERO_CHAR
>> -#define TRACE_ZERO_CHAR(arg)
>> -
>> #undef TRACE_FIELD
>> #define TRACE_FIELD(type, item, assign)\
>> entry->item = assign;
>> @@ -107,6 +104,9 @@ ftrace_format_##call(struct ftrace_event_call *unused, \
>> #define TRACE_FIELD_SIGN(type, item, assign, is_signed) \
>> TRACE_FIELD(type, item, assign)
>>
>> +#undef TRACE_FIELD_ZERO
>> +#define TRACE_FIELD_ZERO(type, item)
>> +
>
>
>
> Is it about the above moving?
> If so, could you just tell so that I can add something about
> it in the changelog.
No, I assume that TRACE_ZERO_CHAR is just a typo of TRACE_FIELD_ZERO_CHAR.
(because I couldn't find any other TRACE_ZERO_CHAR)
BTW, this patch may not be needed after applying patch 10/12, since
it removes ftrace event definitions of TRACE_KPROBE/KRETPROBE.
Perhaps, would I better merge and split those additional patches(and
remove this change)?
(It also could make the incremental review hard...)
Thank you,
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists