linux-kernel - Re: [RFC patch 02/32] x86: Add probe_roms to platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0908220034110.1769@localhost.localdomain>
Date:	Sat, 22 Aug 2009 00:36:21 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
cc:	LKML <linux-kernel@...r.kernel.org>, x86 team <x86@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Arjan van de Veen <arjan@...radead.org>,
	Avi Kivity <avi@...hat.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Alok N Kataria <akataria@...are.com>,
	Pan Jacob jun <jacob.jun.pan@...el.com>
Subject: Re: [RFC patch 02/32] x86: Add probe_roms to platform_setup

On Fri, 21 Aug 2009, Jeremy Fitzhardinge wrote:

> On 08/21/09 14:29, Thomas Gleixner wrote:
> [argh attachments]

No. :)

Content-Disposition: inline;
    filename=x86-add-probe-roms-to-platform-setup.patch

> > probe_roms is only used on 32bit. Add it to the platform_setup code
> > and remove the #ifdefs.
> >
> > Default initializer is platform_setup_noop() which is overridden in
> > the 32bit boot code.
> >
> >   
> 
> I realize you're aiming to make this transform have no functional
> side-effects, but is there a good reason why probe_roms *couldn't* be
> done in 64-bit?  It seems to me that its useful for coverage
> completeness to have the 32 and 64 bit do the same thing even if its
> sometimes redundant.

Yes. I aimed for functional equivilance in the first place and this is
a RFC so any improvements are welcome.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/