[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1251128176.7538.301.camel@twins>
Date: Mon, 24 Aug 2009 17:36:16 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Andreas Herrmann <andreas.herrmann3@....com>
Cc: Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 15/15] x86: Fix cpu_coregroup_mask to return correct
cpumask on multi-node processors
On Thu, 2009-08-20 at 15:46 +0200, Andreas Herrmann wrote:
> The correct mask that describes core-siblings of an processor
> is topology_core_cpumask. See topology adapation patches, especially
> http://marc.info/?l=linux-kernel&m=124964999608179
argh, violence, murder kill.. this is the worst possible hack and you're
extending it :/
> Signed-off-by: Andreas Herrmann <andreas.herrmann3@....com>
> ---
> arch/x86/kernel/smpboot.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index f797214..f39bb2c 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -446,7 +446,7 @@ const struct cpumask *cpu_coregroup_mask(int cpu)
> * And for power savings, we return cpu_core_map
> */
> if (sched_mc_power_savings || sched_smt_power_savings)
> - return cpu_core_mask(cpu);
> + return topology_core_cpumask(cpu);
> else
> return c->llc_shared_map;
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists