linux-kernel - Re: [PATCH -tip] v3 Renamings to increase RCU clarity.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090824153658.GD6677@linux.vnet.ibm.com>
Date:	Mon, 24 Aug 2009 08:36:58 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, dipankar@...ibm.com,
	akpm@...ux-foundation.org, mathieu.desnoyers@...ymtl.ca,
	josht@...ux.vnet.ibm.com, dvhltc@...ibm.com, niv@...ibm.com,
	tglx@...utronix.de, peterz@...radead.org, rostedt@...dmis.org
Subject: Re: [PATCH -tip] v3 Renamings to increase RCU clarity.

On Mon, Aug 24, 2009 at 03:17:57PM +0800, Lai Jiangshan wrote:
> Paul E. McKenney wrote:
> > From: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

[ . . . ]

> > +static inline void rcu_read_lock_sched_notrace(void)
> > +{
> > +	preempt_disable_notrace();
> > +}
> 
> It need be marked "notrace". Sometimes a function marked "inline"
> may not be inlined when it is compiled.
> 
> Lai.

Good eyes, and thank you -very- much!!!  I doubt that I would have ever
spotted this on my own, as I was just assuming that the compiler would
see the preempt_disable_notrace() directly in all cases...

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/