| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4A930AE0.2070007@euromail.se> Date: Mon, 24 Aug 2009 23:49:20 +0200 From: Henrik Rydberg <rydberg@...omail.se> To: Andrew Morton <akpm@...ux-foundation.org> CC: nicolas@...chat.ch, lm-sensors@...sensors.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] hwmon: applesmc: restore keyboard backlight on resume Andrew Morton wrote: > On Sat, 22 Aug 2009 23:33:52 +0200 > "Henrik Rydberg" <rydberg@...omail.se> wrote: > >> On resume from suspend, the driver currently resets the logical >> state as if it was brought up from halt. This patch uses the >> dev_pm_ops.resume method to synchronize the hardware with the >> memorized logical state, bringing back the backlight to the level >> prior to suspend. > > What are the runtime effects of this change? The patch has zero impact on a running system, only suspend/resume behavior is affected. Precondition: Suspend computer with keyboard backlight brightness greater than zero. Before patch: On resume, the backlight stays off. After patch: On resume, the backlight is set to the brightness prior to suspend. There is one side-effect of the patch: the accelerometer no longer re-calibrates on resume, but keeps the calibration from before suspend. I consider this a good change, but it is after all a change. Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists