linux-kernel - Re: [PATCH] hwmon: applesmc: restore keyboard backlight on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A932456.9000500@bitmath.org>
Date:	Tue, 25 Aug 2009 01:37:58 +0200
From:	Henrik Rydberg <rydberg@...math.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Henrik Rydberg <rydberg@...omail.se>, nicolas@...chat.ch,
	lm-sensors@...sensors.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: applesmc: restore keyboard backlight on resume

Andrew Morton wrote:
> On Sat, 22 Aug 2009 23:33:52 +0200
> "Henrik Rydberg" <rydberg@...omail.se> wrote:
> 
>> On resume from suspend, the driver currently resets the logical
>> state as if it was brought up from halt. This patch uses the
>> dev_pm_ops.resume method to synchronize the hardware with the
>> memorized logical state, bringing back the backlight to the level
>> prior to suspend.
> 
> What are the runtime effects of this change?
> 

My apologies, the patch has two flaws.

1) For macbook models without keyboard backlight, the resume function
will fail internally, presumably resulting in a small unnecessary delay.

2) The accelerometer does not reset properly after hibernation.

Please drop this patch from -mm, I am sending a corrected patch
with a slightly different title. Sorry about this.

Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/