linux-kernel - Re: [PATCH] tracing/profile: Fix profile_disable vs module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1251093660.7538.119.camel@twins>
Date:	Mon, 24 Aug 2009 08:01:00 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing/profile: Fix profile_disable vs module_unload

On Mon, 2009-08-24 at 12:19 +0800, Li Zefan wrote:
> If the correspoding module is unloaded before ftrace_profile_disable()
> is called, event->profile_disable() won't be called, which can
> cause oops:
> 
>   # insmod trace-events-sample.ko
>   # perf record -f -a -e sample:foo_bar sleep 3 &
>   # sleep 1
>   # rmmod trace_events_sample
>   # insmod trace-events-sample.ko
>   OOPS!
> 
> Signed-off-by: Li Zefan <lizf@...fujitsu.com>


Hrmm, feel fragile, why don't we check if all a modules tracepoints are
unused on unload?

> ---
>  kernel/trace/trace_event_profile.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/trace/trace_event_profile.c b/kernel/trace/trace_event_profile.c
> index 11ba5bb..55a25c9 100644
> --- a/kernel/trace/trace_event_profile.c
> +++ b/kernel/trace/trace_event_profile.c
> @@ -5,6 +5,7 @@
>   *
>   */
>  
> +#include <linux/module.h>
>  #include "trace.h"
>  
>  int ftrace_profile_enable(int event_id)
> @@ -14,7 +15,8 @@ int ftrace_profile_enable(int event_id)
>  
>  	mutex_lock(&event_mutex);
>  	list_for_each_entry(event, &ftrace_events, list) {
> -		if (event->id == event_id && event->profile_enable) {
> +		if (event->id == event_id && event->profile_enable &&
> +		    try_module_get(event->mod)) {
>  			ret = event->profile_enable(event);
>  			break;
>  		}
> @@ -32,6 +34,7 @@ void ftrace_profile_disable(int event_id)
>  	list_for_each_entry(event, &ftrace_events, list) {
>  		if (event->id == event_id) {
>  			event->profile_disable(event);
> +			module_put(event->mod);
>  			break;
>  		}
>  	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/