linux-kernel - Re: [PATCH 13/23] io-controller: Separate out queue and data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A9BEBCF.7000808@redhat.com>
Date:	Mon, 31 Aug 2009 11:27:11 -0400
From:	Rik van Riel <riel@...hat.com>
To:	Vivek Goyal <vgoyal@...hat.com>
CC:	linux-kernel@...r.kernel.org, jens.axboe@...cle.com,
	containers@...ts.linux-foundation.org, dm-devel@...hat.com,
	nauman@...gle.com, dpshah@...gle.com, lizf@...fujitsu.com,
	mikew@...gle.com, fchecconi@...il.com, paolo.valente@...more.it,
	ryov@...inux.co.jp, fernando@....ntt.co.jp, s-uchida@...jp.nec.com,
	taka@...inux.co.jp, guijianfeng@...fujitsu.com, jmoyer@...hat.com,
	dhaval@...ux.vnet.ibm.com, balbir@...ux.vnet.ibm.com,
	righi.andrea@...il.com, m-ikeda@...jp.nec.com, agk@...hat.com,
	akpm@...ux-foundation.org, peterz@...radead.org,
	jmarchan@...hat.com, torvalds@...ux-foundation.org, mingo@...e.hu
Subject: Re: [PATCH 13/23] io-controller: Separate out queue and data

Vivek Goyal wrote:
> o So far noop, deadline and AS had one common structure called *_data which
>   contained both the queue information where requests are queued and also
>   common data used for scheduling. This patch breaks down this common
>   structure in two parts, *_queue and *_data. This is along the lines of
>   cfq where all the reuquests are queued in queue and common data and tunables
>   are part of data.
> 
> o It does not change the functionality but this re-organization helps once
>   noop, deadline and AS are changed to use hierarchical fair queuing.
> 
> o looks like queue_empty function is not required and we can check for
>   q->nr_sorted in elevator layer to see if ioscheduler queues are empty or
>   not.
> 
> Signed-off-by: Nauman Rafique <nauman@...gle.com>
> Signed-off-by: Gui Jianfeng <guijianfeng@...fujitsu.com>
> Signed-off-by: Vivek Goyal <vgoyal@...hat.com>

Acked-by: Rik van Riel <riel@...hat.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/