linux-kernel - Re: [RFC][PATCH]: Adding support for omap-serail driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6a0f7aa0909010710o13021e7hd186f62195d63cdf@mail.gmail.com>
Date:	Tue, 1 Sep 2009 19:40:24 +0530
From:	Govindraj <govindraj.ti@...il.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	vimal singh <vimal.newwork@...il.com>, linux-omap@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>, linux-serial@...r.kernel.org
Subject: Re: [RFC][PATCH]: Adding support for omap-serail driver

On Fri, Aug 28, 2009 at 7:35 PM, Alan Cox<alan@...rguk.ukuu.org.uk> wrote:
>> +#define UART_BASE(uart_no)           (uart_no == UART1) ? OMAP_UART1_BASE :\
>> +                                     (uart_no == UART2) ? OMAP_UART2_BASE :\
>> +                                      OMAP_UART3_BASE
>
> Would be cleaner if this was simply an array (and probably faster)
>
>> +
>> +#define UART_MODULE_BASE(uart_no)    (UART1 == uart_no ? \
>> +                                             IO_ADDRESS(OMAP_UART1_BASE) :\
>> +                                     (UART2 == uart_no ? \
>> +                                             IO_ADDRESS(OMAP_UART2_BASE) :\
>> +                                             IO_ADDRESS(OMAP_UART3_BASE)))
>
> Ditto
>
>> +extern unsigned int fcr[MAX_UARTS];
>> +extern char *saved_command_line;
>
> We really don't wang globals floating around with names like fcr - and
> why is saved command line needed when we have module option parsing
> functions ?
>
>
>> +unsigned int fcr[MAX_UARTS];
>> +unsigned long up_activity;
>
> Not acceptable as global names - too big a risk of clashes
>
>
>
>> +static int serial_omap_startup(struct uart_port *port)
>> +{
>> +     struct uart_omap_port *up = (struct uart_omap_port *)port;
>> +     unsigned long flags;
>> +     int irq_flags = 0;
>> +     int retval;
>> +
>> +     /* Zoom2 has GPIO_102 connected to Serial device:
>> +      * Active High
>> +      */
>> +     if (up->port.flags & UPF_IOREMAP)
>> +             irq_flags |= IRQF_TRIGGER_HIGH;
>
> Don't hijack flags here - especially as a patch is pending that adds a
> separate field for IRQ flags to clean that up properly. Build on top of
> that fix instead


Can you provide me the link to that patch.

-----
Regards,
Govindraj.R
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/