linux-kernel - Re: [PATCH V6 1/2] introduce ALS sysfs class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b2b86520909021222k6cc49456vc3232e488eef9e37@mail.gmail.com>
Date:	Wed, 2 Sep 2009 20:22:45 +0100
From:	Alan Jenkins <sourcejedi.lkml@...glemail.com>
To:	Zhang Rui <rui.zhang@...el.com>
Cc:	Len Brown <lenb@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-acpi <linux-acpi@...r.kernel.org>,
	Greg KH <greg@...ah.com>, Pavel Machek <pavel@....cz>
Subject: Re: [PATCH V6 1/2] introduce ALS sysfs class

On 9/1/09, Zhang Rui <rui.zhang@...el.com> wrote:
>
> Introduce ALS sysfs class.
>
> ALS sysfs class provides a standard sysfs interface for
> Ambient Light Sensor devices.
>
> please read Documentation/ABI/testing/sysfs-class-als for
> detailed sysfs designs.
>
> CC: Pavel Machek <pavel@....cz>
> Acked-by: Greg Kroah-Hartman <gregkh@...e.de>
> Signed-off-by: Zhang Rui <rui.zhang@...el.com>
> ---

> +++ linux-2.6/drivers/als/Kconfig
> @@ -0,0 +1,10 @@
> +#
> +# Ambient Light Sensor sysfs device configuration
> +#
> +
> +menuconfig ALS
> +	tristate "Ambient Light Sensor sysfs device"
> +	help
> +	  This framework provides a generic sysfs interface for
> +	  Ambient Light Sensor devices.
> +	  If you want this support, you should say Y or M here.

Gratuitous nitpick:
Can this option be made non-visible (or hidden behind CONFIG_EMBEDDED)?

Maybe you copied the pattern of the thermal sysfs interface - but the
ACPI thermal driver is useful to keep your computer cool even without
the sysfs interface.  ALS drivers are useless without the sysfs
interface, no?

Regards
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/