linux-kernel - Re: [PATCH] rt2x00: Get rid of duplicate usb id from rt2500usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Sep 2009 16:19:53 +0200
From:	Ivo Van Doorn <ivdoorn@...il.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Amit Kucheria <amit.kucheria@...onical.com>,
	List Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH] rt2x00: Get rid of duplicate usb id from rt2500usb

On Thu, Sep 3, 2009 at 3:27 PM, Johannes Berg<johannes@...solutions.net> wrote:
> On Thu, 2009-09-03 at 15:27 +0300, Amit Kucheria wrote:
>> On 09 Sep 03, Ivo Van Doorn wrote:
>> > > USB_DEVICE(0x148f, 0x2573) is served by the rt73usb driver where it is already
>> > > defined. Remove it from rt2500usb.
>> > >
>> > > Signed-off-by: Amit Kucheria <amit.kucheria@...onical.com>
>> > > Cc: Ivo van Doorn <IvDoorn@...il.com>
>> >
>> > NACK
>> >
>> > Users have reported that this is a valid rt2500usb ID. You can thank the
>> > manufacturer of the dongle to produce dongles with the same USB ID but
>> > with different chipsets.
>> >
>> > Ivo
>>
>> Interesting. On my laptop, without this patch both the drivers are loaded
>> (lsmod), rt2500usb aborts without allocating a device successfully but I am
>> unable to associate to the AP.
>
> Sounds like the detection logic is somehow messing with the device, or
> rt2500usb isn't actually freeing the device for rt73usb to bind?

That would be odd, I believe it is working with other devices with
duplicate ID's
where first rt2500usb is loaded and then rt73usb. As far as connecting to the
device, the first thing rt2x00 does is reading the EEPROM and checking the
chipset. So no registers are being written which could upset a rt73usb device.

Ivo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/