linux-kernel - Re: [PATCH 1/3] x86, msr: add rd/wrmsr interfaces with preset registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AA049F2.5000403@zytor.com>
Date:	Thu, 03 Sep 2009 15:57:54 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Borislav Petkov <petkovbb@...glemail.com>, mingo@...hat.com,
	linux-kernel@...r.kernel.org, kjwinchester@...il.com,
	tglx@...utronix.de, borislav.petkov@....com,
	linux-tip-commits@...r.kernel.org
Subject: Re: [PATCH 1/3] x86, msr: add rd/wrmsr interfaces with preset registers

On 09/03/2009 03:55 PM, Andrew Morton wrote:
> On Mon, 31 Aug 2009 09:50:09 +0200
> Borislav Petkov <petkovbb@...glemail.com> wrote:
> 
>> +.macro op_safe_regs op:req
> 
> Using
> 
> GNU assembler 2.16.1
> 
> I get
> 
> arch/x86/lib/msr-reg.S: Assembler messages:
> arch/x86/lib/msr-reg.S:53: Error: Bad macro parameter list
> arch/x86/lib/msr-reg.S:100: Error: invalid character '_' in mnemonic
> arch/x86/lib/msr-reg.S:101: Error: invalid character '_' in mnemonic
> 
> this:
> 
> diff -puN arch/x86/lib/msr-reg.S~a arch/x86/lib/msr-reg.S
> --- a/arch/x86/lib/msr-reg.S~a
> +++ a/arch/x86/lib/msr-reg.S
> @@ -50,7 +50,7 @@ ENDPROC(native_\op\()_safe_regs)
>  
>  #else /* X86_32 */
>  
> -.macro op_safe_regs op:req
> +.macro op_safe_regs op
>  ENTRY(native_\op\()_safe_regs)
>         CFI_STARTPROC
>         pushl_cfi %ebx
> 
> 
> fixed it.

Yup, already fixed in -tip.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/