linux-kernel - Re: [patch 09/33] fs: dcache scale dentry refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090907074431.GH1875@wotan.suse.de>
Date:	Mon, 7 Sep 2009 09:44:31 +0200
From:	Nick Piggin <npiggin@...e.de>
To:	Eric Paris <eparis@...isplace.org>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 09/33] fs: dcache scale dentry refcount

On Sun, Sep 06, 2009 at 02:01:05PM -0400, Eric Paris wrote:
> On Fri, Sep 4, 2009 at 2:51 AM, <npiggin@...e.de> wrote:
> 
> And yet in this case we do check for dentry->d_parent == dentry.  (my
> unknowing self thinks we'd want to check in all places)

I think you're right, I think we need checks there too...

BTW Is there a way to test the fsnotify code? I thought inotify was
supposed to be implemented with fsnotify, but I see quite a lot
of duplicated (or very similar) code... We've also still got
inotify calls in fs/ (inotify_umount_inodes). and CONFIG_INOTIFY and
CONFIG_FSNOTIFY conditionals in there too. Would it be possible to
move that out into fsnotify calls? (fsnotify_inode_init_once or
whatever).

(Sorry to hijack your good review comments :))

Thanks,
Nick

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/