linux-kernel - Re: [patch 04/33] fs: brlock vfsmount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090907073927.GG1875@wotan.suse.de>
Date:	Mon, 7 Sep 2009 09:39:27 +0200
From:	Nick Piggin <npiggin@...e.de>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 04/33] fs: brlock vfsmount_lock

On Fri, Sep 04, 2009 at 05:19:09PM +0200, Jens Axboe wrote:
> On Fri, Sep 04 2009, npiggin@...e.de wrote:
> > Index: linux-2.6/fs/namei.c
> > ===================================================================
> > --- linux-2.6.orig/fs/namei.c
> > +++ linux-2.6/fs/namei.c
> > @@ -679,15 +679,16 @@ int follow_up(struct path *path)
> >  {
> >  	struct vfsmount *parent;
> >  	struct dentry *mountpoint;
> > -	spin_lock(&vfsmount_lock);
> > +
> > +	vfsmount_read_unlock();
> >  	parent = path->mnt->mnt_parent;
> >  	if (parent == path->mnt) {
> > -		spin_unlock(&vfsmount_lock);
> > +		vfsmount_read_unlock();
> >  		return 0;
> 
> Hmm, that looks a bit off.

Thanks Jens, good catch. Yes I haven't actually even tested NFS or
NFSD yet, which I should do soon because they do some interesting
things with the dcache.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/