linux-kernel - Re: [RFC][PATCH 2/2] disable boot interrupts on Intel X58 and 55x0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 6 Sep 2009 22:37:42 -0300
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	Daniel Walker <dwalker@...o99.com>
Cc:	Olaf Dabrunz <Olaf.Dabrunz@....net>,
	Stefan Assmann <sassmann@...hat.com>,
	linux-kernel@...r.kernel.org, jcm@...hat.com, sdietrich@...ell.com,
	linux-acpi@...r.kernel.org, andi@...stfloor.org, hpa@...or.com,
	mingo@...e.hu, ktokunag@...hat.com, tglx@...utronix.de,
	lenb@...nel.org
Subject: Re: [RFC][PATCH 2/2] disable boot interrupts on Intel X58 and 55x0

On Sat, 05 Sep 2009, Daniel Walker wrote:
> I'm not sure I see how this makes "adding/deleting/modifying" easier ..
> We have lots of other situations where lines are broken down less than
> 80, function arguments, macros, structures all sorts of stuff. 
> 
> Taking this block for instance,
> 
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BROADCOM,
>                         PCI_DEVICE_ID_TIGON3_5780,
>                         quirk_msi_intx_disable_bug);
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BROADCOM,
>                         PCI_DEVICE_ID_TIGON3_5780S,
>                         quirk_msi_intx_disable_bug);
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BROADCOM,
>                         PCI_DEVICE_ID_TIGON3_5714,
>                         quirk_msi_intx_disable_bug);
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BROADCOM,
>                         PCI_DEVICE_ID_TIGON3_5714S,
>                         quirk_msix_intx_disable_bug);
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BROADCOM,
>                         PCI_DEVICE_ID_TIGON3_5715,
>                         quirk_msi_intx_disable_bug);
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BROADCOM,
>                         PCI_DEVICE_ID_TIGON3_5715S,
>                         quirk_msi_intx_disable_bug);

You must have an alien brain of some sort if reading that is easier than the
tabular (single-line) format for you.

Please try finding the one entry in there which is different (I changed one
of them) with a quick glance.  Chances are you'll just skip over it and
think all of them do the same thing.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/