linux-kernel - [PATCH take 3][RFC] fat: Save FAT root directory timestamps to volume label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1252420131.5782.2.camel@jorg-desktop>
Date:	Tue, 08 Sep 2009 17:28:51 +0300
From:	Jörg Schummer <ext-jorg.2.schummer@...ia.com>
To:	hirofumi@...l.parknet.co.jp
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: [PATCH take 3][RFC] fat: Save FAT root directory timestamps to
	volume label

On Tue, 2009-08-04 at 12:32 +0200, ext OGAWA Hirofumi wrote: 
> Jörg Schummer <ext-jorg.2.schummer@...ia.com> writes:
> 
> > On Mon, 2009-07-27 at 13:47 +0200, ext OGAWA Hirofumi wrote:
> >> Jörg Schummer <ext-jorg.2.schummer@...ia.com> writes:
> >
> >> BTW, the patch has several bugs. fat_get_label_entry() doesn't check
> >> IS_FREE(), is it right? fat_create_label_entry() doesn't initialize all
> >> timestamp in the case of msdos. spin_lock() usage is wrong. and more...
> >
> > After reviewing the patch again, I did notice some additional problems
> > (I suppose that was the "and more..."). If and when I have time again, I
> > might take a closer look at it again.
> >
> > Thanks for your help until now!

Hello,

on the off-chance that somebody would like to use this mechanism, I did
a 3rd take of the patch. I tried to fix the problems of the previous
patch and additionally added the functionality to correct the root dir
timestamp's mtime and atime somewhat based on contained directory
entries' ctime.

Any comments are welcome, but especially I'd like to ask if it is safe /
good / doable to call 

  remove_inode_hash(inode);
  fat_attach(inode, i_pos);
  insert_inode_hash(inode);

inside fat_write_inode .

Thanks for any feedback!
Jörg


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/