linux-kernel - Re: [PATCH] char/tty_io: fix legacy pty name when more than 256 pty devices are requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AA96328.1040809@zytor.com>
Date:	Thu, 10 Sep 2009 13:35:52 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Mauro Carvalho Chehab <mchehab@...radead.org>
CC:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Alan Cox <alan@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Kay Sievers <kay.sievers@...y.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH] char/tty_io: fix legacy pty name when more than 256 pty
 devices are requested

On 09/10/2009 01:05 PM, Mauro Carvalho Chehab wrote:
>>
>> Yes, but you have to port the application *anyway* do deal with the
>> namespace.
> 
> Or create some udev rules for that.
> 

udev rules does zero good, because the way the BSD ptys go, the
application itself needs to understand what the naming scheme is.  So it
is an application-by-application slog.

>> BSD tty allocation is done largely by each application,
>> which makes it even worse.  Furthermore, there is the static allocation
>> issue, so unless there is a concrete application which needs this *and*
>> cannot be ported to Unix98 ptys (which is the Right Thing[TM] to do) I
>> think Alan is right.
> 
> The amount of static allocation space can be controlled via pty.legacy_count
> boot parameter. It overrides whatever specified at CONFIG_LEGACY_PTY_COUNT.
> You can even let LEGACY_PTY_COUNT = 0 and enable the actual numbers of needed
> legacy ptys via boot parameter, where needed. So, this is not a problem on a
> real situation.

It still means you are statically allocating a fixed number at boot time.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/