linux-kernel - Re: [PATCH] char/tty_io: fix legacy pty name when more than 256 pty devices are requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090911002329.07d60484@lxorguk.ukuu.org.uk>
Date:	Fri, 11 Sep 2009 00:23:29 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Mauro Carvalho Chehab <mchehab@...radead.org>
Cc:	"H. Peter Anvin" <hpa@...or.com>, Alan Cox <alan@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Kay Sievers <kay.sievers@...y.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH] char/tty_io: fix legacy pty name when more than 256 pty
 devices are requested

> In the case of the BSD sockets, the patch is not just an userless fix. This is

It's useless.

> interesting when some applications are ported from other Unix'es and still uses BSD
> pty's, since several other Unix flavors were defining a higher namespace size.

They won't work because the glibc pty name handling only does the 256
devices. Given glibc still hasn't picked up tty changes from several
years ago I doubt it'll ever pick up a naming change.

BSD pty is dead. It has all sorts of problems including time taken to
find a new port being dependant on ports currently in use. The amount of
code that cares about it is close to nil, that which cares about it uses
glibc BSD pty helper code so won't work with > 256 anyway.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/