linux-kernel - Re: [PATCH 02/10] x86: Convert BUG() to use unreachable()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AA9A031.5000602@zytor.com>
Date:	Thu, 10 Sep 2009 17:56:17 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	David Daney <ddaney@...iumnetworks.com>
CC:	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	Roland McGrath <roland@...hat.com>
Subject: Re: [PATCH 02/10] x86: Convert BUG() to use unreachable()

On 09/10/2009 04:56 PM, David Daney wrote:
> Use the new unreachable() macro instead of for(;;);.  When
> allyesconfig is built with a GCC-4.5 snapshot on i686 the size of the
> text segment is reduced by 3987 bytes (from 6827019 to 6823032).
> 
> Signed-off-by: David Daney <ddaney@...iumnetworks.com>
> CC: Thomas Gleixner <tglx@...utronix.de>
> CC: Ingo Molnar <mingo@...hat.com>
> CC: "H. Peter Anvin" <hpa@...or.com>
> CC: x86@...nel.org

Acked-by: H. Peter Anvin <hpa@...or.com>

... although of course this clashes with Roland McGrath's patchset for
the same thing which I applied earlier.  I have to say I like
unreachable() in lower case better though...

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/