linux-kernel - Re: [PATCH] [14/21] HWPOISON: shmem: call set_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090911215647.GF32562@basil.fritz.box>
Date:	Fri, 11 Sep 2009 23:56:47 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Andi Kleen <andi@...stfloor.org>, fengguang.wu@...el.com,
	linux-kernel@...r.kernel.org,
	"hugh.dickins" <hugh.dickins@...cali.co.uk>
Subject: Re: [PATCH] [14/21] HWPOISON: shmem: call set_page_dirty() with
	locked page

> Will it, from now on, be mandatory to dirty pages under PG_lock, and

Only data pages with mapping.

It's not a strict requirement, but if it's not done then in theory
you could not propagate an error if the page gets an memory error
at exactly the wrong time. It's probably only worth caring if you
expect to have a lot of pages like this.

> does this patch correct the last few such cases that didn't yet do that,
> or does it still leave holes?

I believe in metadata it's still widely there, but hwpoison ignores
those pages anyways.

> 
> Can we document the requirements and or holes to it someplace near
> set_page_dirty()?

Ok I'll add a comment there.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/