linux-kernel - Re: [PATCH] [16/21] HWPOISON: The high level memory error handler in the VM v7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090911215745.GG32562@basil.fritz.box>
Date:	Fri, 11 Sep 2009 23:57:45 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Daniel Walker <dwalker@...o99.com>
Cc:	Andi Kleen <andi@...stfloor.org>, npiggin@...e.de, riel@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [16/21] HWPOISON: The high level memory error handler
	in the VM v7

On Fri, Sep 11, 2009 at 01:58:04PM -0700, Daniel Walker wrote:
> On Fri, 2009-09-11 at 21:33 +0200, Andi Kleen wrote:
> > > The rest of your patches are totally clean, except this one .. It has
> > > some warning, but one error in the second ifdef block above ..
> > 
> > That's intentional, fixing it would require a bare , on a single line
> > which would be far uglier what is there today. I refuse to make code
> > ugly just to work around checkpatch.pl
> 
> 
> Like the following is clean, and I don't see why it would work. Although
> I only compile tested it.

That would turn a simple two liner change into a monstrosity of patch.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/