[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8bd0f97a0909131458r8574620pa539876da969eb5f@mail.gmail.com>
Date: Sun, 13 Sep 2009 17:58:20 -0400
From: Mike Frysinger <vapier.adi@...il.com>
To: Felipe Contreras <felipe.contreras@...il.com>
Cc: linux-kernel@...r.kernel.org, Sam Ravnborg <sam@...nborg.org>
Subject: Re: [PATCH 2/5] kbuild: fix warning when domainname is not available
.
On Sun, Sep 13, 2009 at 17:42, Felipe Contreras
<felipe.contreras@...il.com> wrote:
> On Mon, Sep 14, 2009 at 12:12 AM, Mike Frysinger <vapier.adi@...il.com> wrote:
>> On Sun, Sep 13, 2009 at 15:38, Felipe Contreras wrote:
>>> + if $domain; then
>>
>> is this really correct ? i think you meant to use:
>> [ -n "$domain" ]
>
> What is the difference?
>
> $domain unset
> test -n "" -> false
> test -> false
>
> $domain is a valid string
> test -n "string" -> true
> test "string" -> true
except that you didnt invoke `test` anywhere. you're executing the
contents of $domain.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists