linux-kernel - Re: [PATCH 2/5] kbuild: fix warning when domainname is not available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94a0d4530909131504h1a9de951k3719000705a86bbc@mail.gmail.com>
Date:	Mon, 14 Sep 2009 01:04:11 +0300
From:	Felipe Contreras <felipe.contreras@...il.com>
To:	Mike Frysinger <vapier.adi@...il.com>
Cc:	linux-kernel@...r.kernel.org, Sam Ravnborg <sam@...nborg.org>
Subject: Re: [PATCH 2/5] kbuild: fix warning when domainname is not available

On Mon, Sep 14, 2009 at 12:58 AM, Mike Frysinger <vapier.adi@...il.com> wrote:
> .
> On Sun, Sep 13, 2009 at 17:42, Felipe Contreras
> <felipe.contreras@...il.com> wrote:
>> On Mon, Sep 14, 2009 at 12:12 AM, Mike Frysinger <vapier.adi@...il.com> wrote:
>>> On Sun, Sep 13, 2009 at 15:38, Felipe Contreras wrote:
>>>> +  if $domain; then
>>>
>>> is this really correct ?  i think you meant to use:
>>> [ -n "$domain" ]
>>
>> What is the difference?
>>
>> $domain unset
>> test -n "" -> false
>> test -> false
>>
>> $domain is a valid string
>> test -n "string" -> true
>> test "string" -> true
>
> except that you didnt invoke `test` anywhere.  you're executing the
> contents of $domain.

Ahh, I'll update it to:
[ "$domain" ]

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/