linux-kernel - Re: [origin tree boot crash] Revert "selinux: clean up avc node cache when disabling selinux"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e0fb38c0909131603q77141188o47f83325683c2cc@mail.gmail.com>
Date:	Sun, 13 Sep 2009 19:03:08 -0400
From:	Eric Paris <eparis@...isplace.org>
To:	Eric Paris <eparis@...hat.com>
Cc:	Ingo Molnar <mingo@...e.hu>, James Morris <jmorris@...ei.org>,
	Thomas Liu <tliu@...hat.com>, linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [origin tree boot crash] Revert "selinux: clean up avc node cache 
	when disabling selinux"

On Sat, Sep 12, 2009 at 10:28 PM, Eric Paris <eparis@...hat.com> wrote:
> On Sat, 2009-09-12 at 09:24 +0200, Ingo Molnar wrote:

> Something a lot worse than SELinux here.  I added this exact code and
> got this warning.  Something is wrong in the world of
> kmem_cache_destroy.....
>
> static struct kmem_cache *tmp_cachep;
> tmp_cachep = kmem_cache_create("tmp_cache", sizeof(struct avc_node), 0, SLAB_PANIC, NULL);
>        if (tmp_cachep)
>                kmem_cache_destroy(tmp_cachep);
>
> [    0.006076] ------------[ cut here ]------------
> [    0.007019] WARNING: at lib/kobject.c:595 kobject_put+0x6e/0x80()
> [    0.008011] Hardware name:
> [    0.009006] kobject: '<NULL>' (ffff88001f8da128): is not initialized, yet kobject_put() is being called.
> [    0.010005] Modules linked in:
> [    0.011284] Pid: 0, comm: swapper Not tainted 2.6.31-next-20090911 #17
> [    0.012011] Call Trace:

Just for those playing along at home, I sent a series of 3 patches to
fix the invalid creds test and to clear the avc_node_cachep before
freeing it.
http://marc.info/?l=linux-kernel&m=125281056403544&w=2
http://marc.info/?l=linux-kernel&m=125281056403547&w=2
http://marc.info/?l=linux-kernel&m=125281056403550&w=2

I also bisected at least one problem with kmem_cache_destroy which I
posted the bisect results here
http://marc.info/?l=linux-mm&m=125286686917465&w=2
2a38a002fbee06556489091c30b04746222167e4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/