linux-kernel - Re: [GIT BISECT] BUG kmalloc-8192: Object already free from kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1252898739.5793.4.camel@dhcp231-106.rdu.redhat.com>
Date:	Sun, 13 Sep 2009 23:25:39 -0400
From:	Eric Paris <eparis@...hat.com>
To:	Danny Feng <dfeng@...hat.com>
Cc:	cl@...ux-foundation.org, penberg@...helsinki.fi, mingo@...e.hu,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [GIT BISECT] BUG kmalloc-8192: Object already free from
 kmem_cache_destroy

On Mon, 2009-09-14 at 11:18 +0800, Danny Feng wrote:
> diff --git a/mm/slub.c b/mm/slub.c
> index b627675..40e12d5 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -3337,8 +3337,8 @@ struct kmem_cache *kmem_cache_create(const char
> *name, size_t size,
>                                 goto err;
>                         }
>                         return s;
> -               }
> -               kfree(s);
> +               } else
> +                       kfree(s);
>         }
>         up_write(&slub_lock);
>   

Doesn't the return inside the conditional take care of this?  I'll give
it a try in the morning, but I don't see how this can solve the
problem....

-Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/