linux-kernel - Re: [PATCH] TPM: Fixup pcrs sysfs file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1252950736.9372.168.camel@blackbox>
Date:	Mon, 14 Sep 2009 14:52:16 -0300
From:	Rajiv Andrade <srajiv@...ux.vnet.ibm.com>
To:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc:	James Morris <jmorris@...ei.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	Debora Velarde <debora@...ux.vnet.ibm.com>,
	Marcel Selhorst <m.selhorst@...rix.com>,
	Jan Beulich <jbeulich@...ell.com>
Subject: Re: [PATCH] TPM: Fixup pcrs sysfs file

On Mon, 2009-09-14 at 14:45 -0300, Rajiv Andrade wrote:
> On Mon, 2009-09-14 at 00:25 -0600, Jason Gunthorpe wrote:
> > On Mon, Sep 14, 2009 at 12:36:39PM +1000, James Morris wrote:
> > > On Thu, 3 Sep 2009, Jason Gunthorpe wrote:
> > 
> > > > > That sounds like a fairly serious bug, and this looks like a 2.6.31
> > > > > patch.
> > > 
> > > Any comments from the maintainers on this patch?
> > 
> 
> Sorry for the delay, just reviewed the patches and Jason is right,
> Jason's and Andrew's final work (last patch) is great.
> 
> > FWIW, I didn't mention in the patch emails, but all the patches I sent
> > fix regressions that have been introduced in the past couple years by
> > clean up patches that never tested the code paths they alter.
> > 
> 
> Hold on, I tested these functions before when submitting them and they
> worked fine, and, I couldn't figure it out why yet (only guesses), they
> still work for me here, probably due the mishandling of the be32
> formatted value when calling transmit_cmd().

Regardless the testing and what's happening here in my machine, I agree
with you both that these fixes should go to 2.6.31.

Rajiv


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/