linux-kernel - Re: [PATCH] TPM: Fixup pcrs sysfs file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 14 Sep 2009 12:00:39 -0600
From:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:	Rajiv Andrade <srajiv@...ux.vnet.ibm.com>
Cc:	James Morris <jmorris@...ei.org>,
	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] TPM: Fixup pcrs sysfs file

On Mon, Sep 14, 2009 at 02:45:28PM -0300, Rajiv Andrade wrote:

> Sorry for the delay, just reviewed the patches and Jason is right,
> Jason's and Andrew's final work (last patch) is great.

Thnx
 
> > FWIW, I didn't mention in the patch emails, but all the patches I sent
> > fix regressions that have been introduced in the past couple years by
> > clean up patches that never tested the code paths they alter.

> Hold on, I tested these functions before when submitting them and they
> worked fine, and, I couldn't figure it out why yet (only guesses), they
> still work for me here, probably due the mishandling of the be32
> formatted value when calling transmit_cmd().

Ahh, yes, you are right, the pcr thing wouldn't blow up on a LE
system, I'm testing on BE. Didn't notice that subtlety. Sorry

Also please look at the last patch Andrew has queued up:
http://patchwork.kernel.org/patch/45512/

Regards,
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/