linux-kernel - Re: [PATCH] [mmotm] change "getline" to "get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090914152427.71d1fa93.akpm@linux-foundation.org>
Date:	Mon, 14 Sep 2009 15:24:27 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Nitin Gupta <ngupta@...are.org>
Cc:	justinmattock@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [mmotm] change "getline" to "get_line" to avoid C
 library  confusion

On Mon, 14 Sep 2009 09:29:30 +0530
Nitin Gupta <ngupta@...are.org> wrote:

> Reintroduce this change to fix compilation error on mmotm.
> (Original change by Justin P. Mattock)
> 
> Signed-off-by: Nitin Gupta <ngupta@...are.org>
> ---
>  scripts/unifdef.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/unifdef.c b/scripts/unifdef.c
> index 552025e..05a31a6 100644
> --- a/scripts/unifdef.c
> +++ b/scripts/unifdef.c
> @@ -206,7 +206,7 @@ static void             done(void);
>  static void             error(const char *);
>  static int              findsym(const char *);
>  static void             flushline(bool);
> -static Linetype         getline(void);
> +static Linetype         get_line(void);
>  static Linetype         ifeval(const char **);
>  static void             ignoreoff(void);
>  static void             ignoreon(void);
> @@ -512,7 +512,7 @@ process(void)
> 
>  	for (;;) {
>  		linenum++;
> -		lineval = getline();
> +		lineval = get_line();
>  		trans_table[ifstate[depth]][lineval]();
>  		debug("process %s -> %s depth %d",
>  		    linetype_name[lineval],
> @@ -526,7 +526,7 @@ process(void)
>   * help from skipcomment().
>   */
>  static Linetype
> -getline(void)
> +get_line(void)
>  {
>  	const char *cp;


I'm all confused again.  This:

commit d15bd1067b1fcb2b7250d22bc0c7c7fea0b759f7
Author:     Justin P. Mattock <justinmattock@...il.com>
AuthorDate: Sat Mar 7 13:31:29 2009 +0100
Commit:     Sam Ravnborg <sam@...nborg.org>
CommitDate: Sat Mar 7 13:31:29 2009 +0100

    kbuild: fix C libary confusion in unifdef.c due to getline()

went into mainline months ago and afaict nothing has subsequently
changed in that area?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/