linux-kernel - Re: [PATCH] [mmotm] change "getline" to "get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4AAF02A6.2040601@vflare.org>
Date:	Tue, 15 Sep 2009 08:27:42 +0530
From:	Nitin Gupta <ngupta@...are.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	justinmattock@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [mmotm] change "getline" to "get_line" to avoid C library
  confusion

On 09/15/2009 03:54 AM, Andrew Morton wrote:
> On Mon, 14 Sep 2009 09:29:30 +0530
> Nitin Gupta<ngupta@...are.org>  wrote:
>
>> Reintroduce this change to fix compilation error on mmotm.
>> (Original change by Justin P. Mattock)


>
> I'm all confused again.  This:
>
> commit d15bd1067b1fcb2b7250d22bc0c7c7fea0b759f7
> Author:     Justin P. Mattock<justinmattock@...il.com>
> AuthorDate: Sat Mar 7 13:31:29 2009 +0100
> Commit:     Sam Ravnborg<sam@...nborg.org>
> CommitDate: Sat Mar 7 13:31:29 2009 +0100
>
>      kbuild: fix C libary confusion in unifdef.c due to getline()
>
> went into mainline months ago and afaict nothing has subsequently
> changed in that area?
>
>

This is already fixed in mainline but this patch is for mmotm. On mmotm,
this change is not present. So, I'm now having compilation error while
compiling mmotm tree (not mainline):

mmotm/scripts/unifdef.c:209: error: conflicting types for ‘getline’
/usr/include/stdio.h:653: note: previous declaration of ‘getline’ was here
make[3]: *** [scripts/unifdef] Error 1
make[2]: *** [__headers] Error 2
make[1]: *** [vmlinux] Error 2
make: *** [sub-make] Error 2


Thanks,
Nitin




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/