linux-kernel - RE: [patch, resend] x86, perf_counter, bts: optimize BTS overflow handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <928CFBE8E7CB0040959E56B4EA41A77EC47B0E9E@irsmsx504.ger.corp.intel.com>
Date:	Tue, 15 Sep 2009 12:18:23 +0100
From:	"Metzger, Markus T" <markus.t.metzger@...el.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
CC:	"mingo@...e.hu" <mingo@...e.hu>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"hpa@...or.com" <hpa@...or.com>,
	"markus.t.metzger@...il.com" <markus.t.metzger@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [patch, resend] x86, perf_counter, bts: optimize BTS overflow
 handling

>-----Original Message-----
>From: Peter Zijlstra [mailto:a.p.zijlstra@...llo.nl]
>Sent: Tuesday, September 15, 2009 1:12 PM


>> Restructure perf_counter sampling into sample creation and sample
>> output.
>> Prepare a single reference sample for BTS sampling and update the from
>> and to address fields when draining the BTS buffer.
>> Drain the entire BTS buffer between a single perf_output_begin() /
>> perf_output_end() pair.
>
>Generally looks very nice, one thing though, why did you take regs out
>of perf_sample_data, now you get to pass around one extra param..


That is to make perf_sample_data describe the sample directly.

The regs are used to create the sample; they're not needed once
the sample has been created.


>> CC: Peter Zijlstra <a.p.zijlstra@...llo.nl>
>> Signed-off-by: Markus Metzger <markus.t.metzger@...el.com>
>> ---
>>  arch/x86/kernel/cpu/perf_counter.c |   60 	37 +	23 -	0 !
>>  include/linux/perf_counter.h       |   68 	64 +	4 -	0 !
>>  kernel/perf_counter.c              |  306 	161 +	145 -	0 !
>>  3 files changed, 262 insertions(+), 172 deletions(-)
>
>What is that diffstat thing? I always get things like:
>
> kernel/sched.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>

I'm using QUILT_DIFFSTAT_OPTS="-f0".

regards,
markus.
---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/