linux-kernel - Re: [PATCH] arm: remove unused code in delay.S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94a0d4530909151158y489a96e3x63ff932c713822b0@mail.gmail.com>
Date:	Tue, 15 Sep 2009 21:58:19 +0300
From:	Felipe Contreras <felipe.contreras@...il.com>
To:	Steve Chen <schen@...sta.com>
Cc:	Marek Vasut <marek.vasut@...il.com>, Pavel Machek <pavel@....cz>,
	Jamie Lokier <jamie@...reable.org>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm: remove unused code in delay.S

On Tue, Sep 15, 2009 at 7:30 PM, Steve Chen <schen@...sta.com> wrote:
> On Tue, 2009-09-15 at 15:41 +0200, Marek Vasut wrote:
>> > -#if 0
>> > +#if CONFIG_OLD_CPU_DELAY
>>
>> ifdef please
>>
> I assume this a vote in favor of considering this patch as an
> alternative :)  The updated patch is below.  Since I'm only summarizing
> the e-mail thread and put them into a patch (which is a less time
> consuming process than continue reading and deleting e-mails on this
> thread), contributors can add signed off before submitting to Russel.
>
> Document #if 0 code block in delay.S and make it selectable for compile.

Nice :)

A few nitpicks though:

> Signed-off-by: Steve Chen <schen@...sta.com>
>
> ---
>
>  arch/arm/Kconfig     |    8 ++++++++
>  arch/arm/lib/delay.S |    2 +-
>  2 files changed, 9 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index aef63c8..ca8d535 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -813,6 +813,14 @@ config ARM_ERRATA_460075
>          ACTLR register. Note that setting specific bits in the ACTLR
> register
>          may not be available in non-secure mode.
>
> +config OLD_CPU_DELAY
> +       depends on CPU_32v3 || CPU_32v4 || CPU_32v4T
> +       bool "Accurate delays for older CPU"

s/older CPU/old CPUs/

Or even better, since this option will only appear on older CPUs:
"Accurate delays"

> +       def_bool n
> +       help
> +         Enable if observing longer than expected delays and need more
> +         accurate delays on older CPUs.

How about:
> +         Enable if observing longer than expected delays and need more
> +         accuracy. This should only be considered for old CPUs (e.g. foo, bar).

Cheers.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/