linux-kernel - Re: [PATCH 1/3] backlight: Provide two stage registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Sep 2009 20:42:15 +0100
From:	Richard Purdie <rpurdie@...ys.net>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] backlight: Provide two stage registration

On Tue, 2009-09-15 at 20:27 +0100, Matthew Garrett wrote:
> On Tue, Sep 15, 2009 at 08:18:42PM +0100, Richard Purdie wrote:
> 
> > Could we not pass an optional pointer to a properties structure to
> > create the backlight with instead or find a better way to solve this?
> 
> That'd work, but it'd involve significant refactoring of all the 
> drivers - we really need to be setting max_brightness before 
> device_register() is called. I suspect it'd be an even larger delta 
> against mainline.

But the delta would result in more readable code rather than all that
error checking/handling. Can we see how ugly that diff turns out to be?

Cheers,

Richard

-- 
Richard Purdie
Intel Open Source Technology Centre

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/