linux-kernel - Re: [PATCH 06/20] mem_class: use minor as index instead of searching the array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Sep 2009 21:46:25 +0200
From:	Kay Sievers <kay.sievers@...y.org>
To:	Daniel Walker <dwalker@...o99.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/20] mem_class: use minor as index instead of searching 
	the array

On Tue, Sep 15, 2009 at 21:42, Daniel Walker <dwalker@...o99.com> wrote:
> On Tue, 2009-09-15 at 12:12 -0700, Greg Kroah-Hartman wrote:
>> +static const struct memdev {
>> +       const char *name;
>> +       const struct file_operations *fops;
>> +       struct backing_dev_info *dev_info;
>> +} devlist[] = {
>> +       [ 1] = { "mem", &mem_fops, &directly_mappable_cdev_bdi },
>
> This patch has several checkpatch errors wrt. the spacing used in the
> array index..
>
> Kay, can you send a follow up patch to correct them?

I think they are fine, and properly aligned to be best readable.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/