| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Sep 2009 15:24:51 +0200 From: Jens Axboe <jens.axboe@...cle.com> To: linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org Cc: chris.mason@...cle.com, hch@...radead.org, tytso@....edu, akpm@...ux-foundation.org, jack@...e.cz, trond.myklebust@....uio.no, Nick Piggin <npiggin@...e.de>, Jens Axboe <jens.axboe@...cle.com> Subject: [PATCH 13/16] writeback: remove smp_mb(), it's not needed with list_add_tail_rcu() From: Nick Piggin <npiggin@...e.de> list_add_tail_rcu contains required barriers. Signed-off-by: Nick Piggin <npiggin@...e.de> Signed-off-by: Jens Axboe <jens.axboe@...cle.com> --- fs/fs-writeback.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 3475775..59c99e7 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -151,10 +151,10 @@ static void bdi_queue_work(struct backing_dev_info *bdi, struct bdi_work *work) BUG_ON(!bdi->wb_cnt); /* - * Make sure stores are seen before it appears on the list + * list_add_tail_rcu() contains the necessary barriers to + * make sure the above stores are seen before the item is + * noticed on the list */ - smp_mb(); - spin_lock(&bdi->wb_lock); list_add_tail_rcu(&work->list, &bdi->work_list); spin_unlock(&bdi->wb_lock); -- 1.6.4.1.207.g68ea -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists