linux-kernel - Re: [PATCH] Add uboot commandline argument passing support to m68knommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1253291944.7060.42.camel@desktop>
Date:	Fri, 18 Sep 2009 09:39:04 -0700
From:	Daniel Walker <dwalker@...o99.com>
To:	Lennart Sorensen <lsorense@...lub.uwaterloo.ca>
Cc:	linux-kernel@...r.kernel.org, Greg Ungerer <gerg@...inux.org>,
	uclinux-dev@...inux.org
Subject: Re: [PATCH] Add uboot commandline argument passing support to
 m68knommu

On Fri, 2009-09-18 at 12:27 -0400, Lennart Sorensen wrote:
> +
> +       if (uboot_cmd_start && uboot_cmd_end) {
> +               strncpy(commandp, (const char *)uboot_cmd_start,
> size);
> +       }
> +#if defined(CONFIG_BLK_DEV_INITRD)
> +       if (uboot_initrd_start && uboot_initrd_end && 
> +               (uboot_initrd_end > uboot_initrd_start))
> {              
> +               initrd_start = uboot_initrd_start;
> +               initrd_end = uboot_initrd_end;
> +               ROOT_DEV = Root_RAM0;
> +               printk("initrd at 0x%lx:0x%lx\n", 
> +                       initrd_start, initrd_end);
> +       }
> +#endif /* if defined(CONFIG_BLK_DEV_INITRD) */
> +}

You have a couple of various checkpatch errors in this patch. We use
scripts/checkpatch.pl to check for code style issues. Could you run that
on your patch and fix any errors it finds? A couple are whitespace
related and you can use scripts/cleanpatch or scripts/cleanfile to
remove whitespace (so I hear. I've never run those scripts personally)

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/