linux-kernel - Re: [PATCH] Input: add MAX7359 key switch controller driver, v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090918163927.GA365@core.coreip.homeip.net>
Date:	Fri, 18 Sep 2009 09:39:27 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Joonyoung Shim <jy0922.shim@...sung.com>
Cc:	Marek Szyprowski <m.szyprowski@...sung.com>,
	'Trilok Soni' <soni.trilok@...il.com>,
	'Kim Kyuwon' <q1.kim@...sung.com>,
	'Kim Kyuwon' <chammoru@...il.com>,
	'LKML' <linux-kernel@...r.kernel.org>,
	linux-input@...r.kernel.org,
	'Kyungmin Park' <kyungmin.park@...sung.com>
Subject: Re: [PATCH] Input: add MAX7359 key switch controller driver, v2

Hi Joonyoung,

On Fri, Sep 18, 2009 at 05:14:39PM +0900, Joonyoung Shim wrote:
> 
> Hi, Dmitry.
> 
> I tested your patch with threaded IRQ. Because the interrupt of the 
> MAX7359 device is the low level detecting, i should add the IRQF_ONESHOT 
> flag on request_threaded_irq(). If it is added IRQF_ONESHOT flag, the it
> operates well.

Thank you for testing.

> Do you want i send the patch?

No, I fixed it locally. I took the liberty of marking the patch as
"Tested-by" you, I hope you don't mind.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/