linux-kernel - Re: [tip:core/printk] ratelimit: Fix/allow use in atomic contexts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.01.0909220745420.4950@localhost.localdomain>
Date:	Tue, 22 Sep 2009 07:46:19 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	a.p.zijlstra@...llo.nl, davem@...emloft.net,
	akpm@...ux-foundation.org, tglx@...utronix.de, mingo@...e.hu
cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:core/printk] ratelimit: Fix/allow use in atomic contexts




On Tue, 22 Sep 2009, tip-bot for Ingo Molnar wrote:
> 
> ratelimit: Fix/allow use in atomic contexts
> 
> I'd like to use printk_ratelimit() in NMI context, but it's not
> robust right now due to spinlock usage in lib/ratelimit.c. If an
> NMI is unlucky enough to hit just that spot we might lock up trying
> to take the spinlock again.
> 
> Fix that by using a trylock variant. If we contend on that lock we
> can genuinely skip the message because the state is just being
> accessed by another CPU (or by this CPU).

Ack to both this and the patch leading up to it. Looks sane and simple.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/