linux-kernel - Re: [perf] Finding uninstalled modules Was Re: mailing list for trace users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090923083751.GB6464@ghostprotocols.net>
Date:	Wed, 23 Sep 2009 01:37:52 -0700
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Avi Kivity <avi@...hat.com>
Cc:	Mike Galbraith <efault@....de>, rostedt@...dmis.org,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Masami Hiramatsu <mhiramat@...hat.com>
Subject: Re: [perf] Finding uninstalled modules Was Re: mailing list for
	trace users

Em Wed, Sep 23, 2009 at 11:31:04AM +0300, Avi Kivity escreveu:
> On 09/22/2009 11:17 PM, Arnaldo Carvalho de Melo wrote:
>>
>>> $ perf annotate -v -v -k ~avi/kvm/linux-2.6/vmlinux -m vmx_vcpu_run  |
>>>      
>> Here is the problem, he is passing a vmlinux, that way we don't parse
>> /proc/kallsyms, so no module symbols, he uses -m to load the modules
>> symbols but mod_dso__load_module_paths only looks at /lib/modules/, i.e.
>> installed modules.
>>
>> I guess Avi hasn't installed modules, right? So the right fix for this
>> case is to figure out where modules are from the path given to -k, i.e.
>> we first use ~avi/kvm/linux-2.6/ as the modules path prefix and then
>> fallback to /lib/modules if we can't find modules there, right?
>>    
>
> Modules were installed (I always load them with modprobe).  It's  
> possible that the installed modules were a later version than the loaded  
> modules, but Mike's reply leads me to believe there was a real bug there.

Yeah, I'm rewriting the module symbol lookup code in perf, they should
really be maps backed by DSOs, just like shared libraries, only that
shared among all threads.

Will continue working on this tomorrow. Now need to get some sleep, else
I'll miss the first day of plumbers 8)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/