linux-kernel - Re: checkpatch as a tool (was Re: [RFC][PATCH] SCHED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1253716990.20648.31.camel@desktop>
Date:	Wed, 23 Sep 2009 07:43:10 -0700
From:	Daniel Walker <dwalker@...o99.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Joe Perches <joe@...ches.com>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
	Jonathan Corbet <corbet@....net>
Subject: Re: checkpatch as a tool (was Re: [RFC][PATCH] SCHED_EDF
 scheduling class)

On Wed, 2009-09-23 at 14:22 +0200, Ingo Molnar wrote:
> He should consider not sending them at all. It's up to maintainers and 
> the developers involved with that code whether the small details that 
> checkpatch flags are important or not at a given point in the patch 
> cycle.
> 
> For example i use checkpatch all the time and i think it's a fantastic 
> tool, still i dont want another nuisance layer on lkml interfering with 
> the patch flow.
> 
> If a patch gets so far in the patch cycle that i'm thinking about 
> merging it, i might fix the checkpatch failures myself (often they are 
> trivial), and i might warn frequent contributors about repeat patterns 
> of small uncleanlinesses - or i might bounce the patch back to the 
> contributor. I also ignore certain classes of checkpatch warnings.
> 
> What Daniel is doing is basically a semi-mandatory checkpatch layer on 
> lkml and that's both a distraction and harmful as well. We dont need a 
> "checkpatch police" on lkml. We want an open, reasonable, human driven 
> patch process with very little buerocracy and no buerocrats.

I think short term you might be right, that it is a nuisance to deal
with these issues.. However, these are real code comments which is what
this list is designed for.. Long term I don't think I will be sending
many of these emails at all, in fact I've only been doing this 3 weeks
and I can already see a drop off in the number of errors that I'm
finding.. It's like advertising, as soon as people start seeing a lot of
checkpatch related emails, they start to remember to use the tool.

Not to mention that automated code review (in mass) is useful .. Our
eyes can miss things, and having a massively used tool that checks for
all the common problems that we encounter is a good thing.. For
instance, checkpatch already found a locked semaphore, and a mutex type
semaphore in the "Target_Core_Mod ConfigFS infrastructure", which I'm
sure no one would want to enter the kernel, but had been missed. It also
found one real code defect, 

http://lkml.indiana.edu/hypermail/linux/kernel/0909.1/00129.html

The more we use the tool the better the tool becomes, and the more real
problems can be caught prior to code inclusion ..

I could have a higher threshold for when these errors become note
worthy, and I've been struggling with that since I started doing this..
I don't think not commenting at all would be a good thing..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/