linux-kernel - Re: [RFC Patch] kbuild: remove -Wdeclaration-after-statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ABD25AC.30705@oracle.com>
Date:	Fri, 25 Sep 2009 13:18:52 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Sam Ravnborg <sam@...nborg.org>
CC:	Amerigo Wang <amwang@...hat.com>, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [RFC Patch] kbuild: remove -Wdeclaration-after-statement

Sam Ravnborg wrote:
> On Wed, Sep 23, 2009 at 05:38:01AM -0400, Amerigo Wang wrote:
>> I got lots of "ISO C90 forbids mixed declarations and code" warnings
>> during compile today's kernel.
>>
>> I think we can remove the gcc option '-Wdeclaration-after-statement'
>> now, since we already have C99 for 10 years. :)
> 
> This is a matter of style more than what C99 allows.
> Kernel style is to fobid this(*) so we keep the warning.

Agreed.

> (*) Based on reading several threads where this has
> been mentioned - I have no specific references to CodingStyle.

I've avoided making updates to CodingStyle lately.
Is this one needed?

Thanks,
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/