linux-kernel - Re: [RFC Patch] kbuild: remove -Wdeclaration-after-statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090923105157.GA31281@merkur.ravnborg.org>
Date:	Wed, 23 Sep 2009 12:51:57 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Amerigo Wang <amwang@...hat.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [RFC Patch] kbuild: remove -Wdeclaration-after-statement

On Wed, Sep 23, 2009 at 05:38:01AM -0400, Amerigo Wang wrote:
> 
> I got lots of "ISO C90 forbids mixed declarations and code" warnings
> during compile today's kernel.
> 
> I think we can remove the gcc option '-Wdeclaration-after-statement'
> now, since we already have C99 for 10 years. :)

This is a matter of style more than what C99 allows.
Kernel style is to fobid this(*) so we keep the warning.

(*) Based on reading several threads where this has
been mentioned - I have no specific references to CodingStyle.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/