linux-kernel - Re: [RFC Patch] kbuild: remove -Wdeclaration-after-statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090923104151.GA22262@cmpxchg.org>
Date:	Wed, 23 Sep 2009 12:41:51 +0200
From:	Johannes Weiner <hannes@...xchg.org>
To:	Amerigo Wang <amwang@...hat.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Sam Ravnborg <sam@...nborg.org>
Subject: Re: [RFC Patch] kbuild: remove -Wdeclaration-after-statement

Hi,

On Wed, Sep 23, 2009 at 05:38:01AM -0400, Amerigo Wang wrote:
> 
> I got lots of "ISO C90 forbids mixed declarations and code" warnings
> during compile today's kernel.

Yeah, see http://lkml.org/lkml/2009/9/22/585 .

> I think we can remove the gcc option '-Wdeclaration-after-statement'
> now, since we already have C99 for 10 years. :)

It's still ugly and uncommon to have variable declarations appear
randomly in block bodies, please keep the warning.

> Signed-off-by: WANG Cong <amwang@...hat.com>
> Cc: Sam Ravnborg <sam@...nborg.org>
> 
> ---
> diff --git a/Makefile b/Makefile
> index 433493a..038bda2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -559,9 +559,6 @@ endif
>  NOSTDINC_FLAGS += -nostdinc -isystem $(shell $(CC) -print-file-name=include)
>  CHECKFLAGS     += $(NOSTDINC_FLAGS)
>  
> -# warn about C99 declaration after statement
> -KBUILD_CFLAGS += $(call cc-option,-Wdeclaration-after-statement,)
> -
>  # disable pointer signed / unsigned warnings in gcc 4.0
>  KBUILD_CFLAGS += $(call cc-option,-Wno-pointer-sign,)

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/