linux-kernel - Re: [tip:tracing/core] tracing/bkl: Add bkl ftrace events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1253959554.12145.88.camel@frodo>
Date:	Sat, 26 Sep 2009 06:05:54 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	linux-kernel@...r.kernel.org, mingo@...hat.com, hpa@...or.com,
	fweisbec@...il.com, lizf@...fujitsu.com, tglx@...utronix.de
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:tracing/core] tracing/bkl: Add bkl ftrace events

On Fri, 2009-09-25 at 06:19 +0000, tip-bot for Frederic Weisbecker
wrote:
> Commit-ID:  96a2c464de07d7c72988db851c029b204fc59108

> +#if !defined(_TRACE_BKL_H) || defined(TRACE_HEADER_MULTI_READ)
> +#define _TRACE_BKL_H
> +
> +#include <linux/tracepoint.h>
> +
> +TRACE_EVENT(lock_kernel,
> +
> +	TP_PROTO(const char *func, const char *file, int line),
> +
> +	TP_ARGS(func, file, line),
> +
> +	TP_STRUCT__entry(
> +		__field(	int,		lock_depth		)

FYI,

By your request I added this as a common field ;-)

With commit:

 637e7e864103a7a68c1ce43ada27dfc25c0d113f

But since other utilities outside of ftrace may use this trace point, it
may be OK to keep the duplicate information in the kernel lock API trace
points.

-- Steve

> +		__field_ext(	const char *,	func, FILTER_PTR_STRING	)
> +		__field_ext(	const char *,	file, FILTER_PTR_STRING	)
> +		__field(	int,		line			)
> +	),
> +
> +	TP_fast_assign(
> +		/* We want to record the lock_depth after lock is acquired */
> +		__entry->lock_depth = current->lock_depth + 1;
> +		__entry->func = func;
> +		__entry->file = file;
> +		__entry->line = line;
> +	),
> +
> +	TP_printk("depth: %d, %s:%d %s()", __entry->lock_depth,
> +		  __entry->file, __entry->line, __entry->func)
> +);
> +

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/