linux-kernel - Re: [tip:tracing/core] tracing/bkl: Add bkl ftrace events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090928084836.GA6142@nowhere>
Date:	Mon, 28 Sep 2009 10:48:38 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, mingo@...hat.com, hpa@...or.com,
	lizf@...fujitsu.com, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:tracing/core] tracing/bkl: Add bkl ftrace events

On Sat, Sep 26, 2009 at 06:05:54AM -0400, Steven Rostedt wrote:
> On Fri, 2009-09-25 at 06:19 +0000, tip-bot for Frederic Weisbecker
> wrote:
> > Commit-ID:  96a2c464de07d7c72988db851c029b204fc59108
> 
> > +#if !defined(_TRACE_BKL_H) || defined(TRACE_HEADER_MULTI_READ)
> > +#define _TRACE_BKL_H
> > +
> > +#include <linux/tracepoint.h>
> > +
> > +TRACE_EVENT(lock_kernel,
> > +
> > +	TP_PROTO(const char *func, const char *file, int line),
> > +
> > +	TP_ARGS(func, file, line),
> > +
> > +	TP_STRUCT__entry(
> > +		__field(	int,		lock_depth		)
> 
> FYI,
> 
> By your request I added this as a common field ;-)
> 
> With commit:
> 
>  637e7e864103a7a68c1ce43ada27dfc25c0d113f
> 
> But since other utilities outside of ftrace may use this trace point, it
> may be OK to keep the duplicate information in the kernel lock API trace
> points.
> 
> -- Steve




Right, or may be we can define this tracepoint as a latency format
user by default. It's not possible yet for an event to do that but
I guess we can set a flag for this purpose or something...

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/