linux-kernel - Re: something wrong in drivers/power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090927173516.GB6710@elf.ucw.cz>
Date:	Sun, 27 Sep 2009 19:35:16 +0200
From:	Pavel Machek <pavel@....cz>
To:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
Cc:	rpurdie@...ys.net, lenz@...wisc.edu,
	kernel list <linux-kernel@...r.kernel.org>,
	Dirk@...er-Online.de, arminlitzel@....de,
	Cyril Hrubis <metan@....cz>, thommycheck@...il.com,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	omegamoon@...il.com, eric.y.miao@...il.com, utx@...guin.cz,
	cbou@...l.ru
Subject: Re: something wrong in drivers/power

On Sat 2009-09-26 18:55:36, Dmitry Eremin-Solenikov wrote:
> On Sat, Sep 26, 2009 at 11:55:55AM +0200, Pavel Machek wrote:
> > 
> > Tosa battery driver seems to be confused about its own identity.
> 
> NAK. Please see the drivers/input/touchscree/wm97xx-core.c

Could you elaborate? 

I took a look at touchscreen file, and it does not explain
anything. Having tosa_battery calling itself wm97xx-battery is at
least confusing, and there's no explaining comment. Given that we have
different wm97xx_battery.c driver calling itself "wm97xx-battery"... I
believe that's a bug.

								Pavel

> > Signed-off-by: Pavel Machek <pavel@....cz>
> > 
> > diff -ur power.ofic/tosa_battery.c power/tosa_battery.c
> > --- linux/drivers/power.ofic/tosa_battery.c	2009-09-06 08:56:36.000000000 +0200
> > +++ linux/drivers/power/tosa_battery.c	2009-09-15 15:14:08.000000000 +0200
> > @@ -459,7 +459,7 @@
> >  }
> >  
> >  static struct platform_driver tosa_bat_driver = {
> > -	.driver.name	= "wm97xx-battery",
> > +	.driver.name	= "tosa-battery",
> >  	.driver.owner	= THIS_MODULE,
> >  	.probe		= tosa_bat_probe,
> >  	.remove		= __devexit_p(tosa_bat_remove),
> > @@ -483,4 +483,4 @@
> >  MODULE_LICENSE("GPL");
> >  MODULE_AUTHOR("Dmitry Baryshkov");
> >  MODULE_DESCRIPTION("Tosa battery driver");
> > -MODULE_ALIAS("platform:wm97xx-battery");
> > +MODULE_ALIAS("platform:tosa-battery");
> > 
> > 
> > -- 
> > (english) http://www.livejournal.com/~pavelmachek
> > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
> 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/