linux-kernel - Re: [linux-pm] [PATCH, fix] Re: [Regression] 2.6.31-git: tty change broke resume from hibernation on MSI Wind U100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8e1da0909272203me287858y2f8d82f3710e07d3@mail.gmail.com>
Date:	Mon, 28 Sep 2009 13:03:52 +0800
From:	Dave Young <hidave.darkstar@...il.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	Alan Cox <alan@...rguk.ukuu.org.uk>, Greg KH <gregkh@...e.de>,
	pm list <linux-pm@...ts.linux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [linux-pm] [PATCH, fix] Re: [Regression] 2.6.31-git: tty change 
	broke resume from hibernation on MSI Wind U100

On Mon, Sep 28, 2009 at 2:16 AM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> On Sunday 27 September 2009, Alan Stern wrote:
>> On Sun, 27 Sep 2009, Rafael J. Wysocki wrote:
>>
>> > Tested, works.
>> >
>> > Greg, could you please consider taking the patch below?  It fixes a recent
>> > hibernation regression for me, so if not this one, another fix is necessary.
>>
>> This patch has a mistake.
>>
>> > Index: linux-2.6/drivers/usb/serial/usb-serial.c
>> > ===================================================================
>> > --- linux-2.6.orig/drivers/usb/serial/usb-serial.c
>> > +++ linux-2.6/drivers/usb/serial/usb-serial.c
>> > @@ -1210,7 +1210,7 @@ static const struct tty_operations seria
>> >     .chars_in_buffer =      serial_chars_in_buffer,
>> >     .tiocmget =             serial_tiocmget,
>> >     .tiocmset =             serial_tiocmset,
>> > -   .shutdown =             serial_release,
>> > +   .cleanup =              serial_release,
>> >     .install =              serial_install,
>> >     .proc_fops =            &serial_proc_fops,
>> >  };
>>
>> It isn't enough to change the method pointer.  The code in
>> serial_release() has to be changed too; it must not call tty_shutdown()
>> any more.
>
> Would it be sufficient to remove the tty_shutdown() call from
> serial_release()?

I think so, because standard shutdown will be called in queue_release_one_tty.

Alan, could you confirm about this?  Thus I'd like to update the patch.



>
> Rafael
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



-- 
Regards
dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/