lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Sep 2009 15:22:08 +1000 From: Nigel Cunningham <ncunningham@...a.org.au> To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> CC: Wu Fengguang <fengguang.wu@...el.com>, LKML <linux-kernel@...r.kernel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org> Subject: Re: No more bits in vm_area_struct's vm_flags. Hi. KAMEZAWA Hiroyuki wrote: > Seems good to me. > > Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> > But >> + if (vma->vm_hints) >> + return 0; >> return 1; > > Maybe adding a comment (or more detailed patch description) is necessary. Thinking about this some more, I think we should also be looking at whether the new hints are non zero. Perhaps I should just add the new value to the function parameters and be done with it. Nigel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists