linux-kernel - Re: [PATCH] Remove pty_ops_bsd and pty_bsd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <395.1254239745@redhat.com>
Date:	Tue, 29 Sep 2009 16:55:45 +0100
From:	David Howells <dhowells@...hat.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	dhowells@...hat.com, Alan Cox <alan@...rguk.ukuu.org.uk>,
	akpm@...ux-foundation.org, gregkh@...e.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Remove pty_ops_bsd and pty_bsd_ioctl() as they're not used

Linus Torvalds <torvalds@...ux-foundation.org> wrote:

>  
>  	pty_slave_driver->owner = THIS_MODULE;
>  	pty_slave_driver->driver_name = "pty_slave";
> @@ -399,7 +387,7 @@ static void __init legacy_pty_init(void)
>  	pty_slave_driver->flags = TTY_DRIVER_RESET_TERMIOS |
>  					TTY_DRIVER_REAL_RAW;
>  	pty_slave_driver->other = pty_driver;
> -	tty_set_operations(pty_slave_driver, &pty_ops);
> +	tty_set_operations(pty_slave_driver, &pty_ops_bsd);
>  
>  	if (tty_register_driver(pty_driver))
>  		panic("Couldn't register pty driver");
> 

Is it right to use pty_ops_bsd in _both_ places?  Looking at the code in
linux-2.6.0, the BSD ioctl only applies to the master and doesn't apply to the
slave.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/