linux-kernel - Re: [PATCH] Remove pty_ops_bsd and pty_bsd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090929233952.2c224303@lxorguk.ukuu.org.uk>
Date:	Tue, 29 Sep 2009 23:39:52 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	David Howells <dhowells@...hat.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	dhowells@...hat.com, akpm@...ux-foundation.org, gregkh@...e.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Remove pty_ops_bsd and pty_bsd_ioctl() as they're not
 used

On Tue, 29 Sep 2009 19:40:10 +0100
David Howells <dhowells@...hat.com> wrote:

> Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> 
> > Comments?
> 
> Perhaps add legacy pty support to the list of features to be removed and see
> who howls.

You do break stuff still and they are part of the API, ABI and namespace
so you break compatibility.

> >  static struct tty_driver *pty_driver, *pty_slave_driver;
> 
> These shouldn't be global variables.  They're only used within
> legacy_pty_init().  That's a side issue, however.

Agreed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/